Skip to content

Commit

Permalink
Uplift third_party/tt-metal to a6ec1c0a02c3b9dc55e769618639e0439ef9c0…
Browse files Browse the repository at this point in the history
…6b 2025-01-13 (#1752)

This PR uplifts the third_party/tt-metal to the
a6ec1c0a02c3b9dc55e769618639e0439ef9c06b
- This brings 1D tensor fix for forge fails blocking uplifts recently,
and increased matmul precision fixes in some caes
 - Remove halo=false on ShardSpec, was removed in tt-metal at df59448e

---------

Co-authored-by: kmitrovicTT <[email protected]>
Co-authored-by: Kyle Mabee <[email protected]>
  • Loading branch information
3 people authored Jan 14, 2025
1 parent 5b4122a commit b8d7d06
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/OpModel/TTNN/Conversion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ getShardSpec(const mlir::tt::ttnn::TTNNLayoutAttr &layout) {
return isShardedMemoryLayout(layout.getMemLayout().getValue())
? std::make_optional(ShardSpec(getCoreRangeSet(layout),
getShardShape(layout),
ShardOrientation::ROW_MAJOR, false))
ShardOrientation::ROW_MAJOR))
: std::nullopt;
}

Expand Down
2 changes: 1 addition & 1 deletion runtime/lib/ttnn/include/tt/runtime/ttnn/utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ createMemoryConfig(const ::tt::target::TensorRef *tensorRef) {

::tt::tt_metal::ShardSpec shardSpec(
ttnnCoreRangeSet, ttnnShardShape,
::tt::tt_metal::ShardOrientation::ROW_MAJOR, false);
::tt::tt_metal::ShardOrientation::ROW_MAJOR);

std::optional<::tt::tt_metal::ShardSpec> shardSpecOpt =
ttnnMemLayout == tt_metal::TensorMemoryLayout::INTERLEAVED
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ createMemoryConfig(const ::tt::target::MemoryConfigDesc *memcfg,

::tt::tt_metal::ShardSpec shardSpec(
ttnnCoreRangeSet, ttnnShardShape,
::tt::tt_metal::ShardOrientation::ROW_MAJOR, false);
::tt::tt_metal::ShardOrientation::ROW_MAJOR);

::ttnn::MemoryConfig memoryConfig = {
tensorMemoryLayout, bufferType,
Expand Down
1 change: 0 additions & 1 deletion test/unittests/OpModel/TTNN/Conversion/TestConversion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ TEST_P(ShardSpecFixture, ShardSpec) {
// Purpose of testing them is to update the test
// if the compiler side changes.
EXPECT_EQ(shardSpec->orientation, ShardOrientation::ROW_MAJOR);
EXPECT_EQ(shardSpec->halo, false);
EXPECT_EQ(shardSpec->mode, ShardMode::PHYSICAL);
EXPECT_EQ(shardSpec->physical_shard_shape.has_value(), false);
}
Expand Down
2 changes: 1 addition & 1 deletion third_party/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
include(ExternalProject)

set(TT_METAL_VERSION "9c5a0b2e0a0edba747613d2afb3e56dacb5776ac")
set(TT_METAL_VERSION "a6ec1c0a02c3b9dc55e769618639e0439ef9c06b")

if ("$ENV{ARCH_NAME}" STREQUAL "grayskull")
set(ARCH_NAME "grayskull")
Expand Down

0 comments on commit b8d7d06

Please sign in to comment.