Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightly Pack CB Indices for Reduce + Fused Ops #18462

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edwinleeTT
Copy link
Contributor

Ticket

#16957
#16958

Problem description

CB indices previously had requirements for the values, such as outputs beginning at 16. These requirements were relaxed but the CB indices remained discontinuous, hurting dispatch performance.

What's changed

This PR changes reduction and normalization ops so that circular buffers use the next available index. This will resolve #16957 and resolve #16958.

Checklist

@edwinleeTT edwinleeTT force-pushed the elee/cb_index_tightening branch from 1f5d48a to 25ce98a Compare February 27, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CB indices tightly packed for fused ops Make CB indices tightly packed for reduce ops
1 participant