Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pre-allgather Layernorm bad PCC when use 1D reduction #16622

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yugaoTT
Copy link
Contributor

@yugaoTT yugaoTT commented Jan 10, 2025

Ticket

Link to Github Issue

Problem description

Currently due to the usage of 2D reduction, the 1d reduction is not tested for Pre-allgather Layernorm, after disable the 2d, it has pcc error.

What's changed

problem is output cb is wrong, changed to correct output cb.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant