Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15450: Remove default values from circular buffer parameters in LLK compute APIs: Test Kernels #16613

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atatuzunerTT
Copy link

Ticket

Link to Github Issue

Problem description

Default values for circular buffer arguments in the LLK compute API can cause errors. Forgetting to set these arguments explicitly may lead to errors due to wrong cb usage. This PR is specific to the changes in the internal test kernel APIs:

  • ./tests/tt_metal/tt_metal/test_kernels/compute/reduce_h.cpp
  • ./tests/tt_metal/tt_metal/test_kernels/compute/reduce_hw.cpp
  • ./tests/tt_metal/tt_metal/test_kernels/compute/reduce_w.cpp
  • ./tests/tt_metal/tt_metal/test_kernels/compute/unpack_tilizeA_B.cpp

What's changed

Default values for the circular buffer parameters have been removed from functions within these files. The call chains invoking these functions have been updated to contain explicit arguments for these parameters.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant