Generate test executables per architecture #16594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/tt-metal into blozano-test-per-arch
blozano-tt
requested review from
mo-tenstorrent,
abhullar-tt and
pgkeller
as code owners
blozano-tt
requested review from
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema and
a team
as code owners
blozano-tt
changed the title
afuller-TT
reviewed
Jan 13, 2025
afuller-TT
reviewed
Jan 13, 2025
afuller-TT
approved these changes
Jan 13, 2025
Co-authored-by: Andrew Fuller <[email protected]>
tt-aho
approved these changes
Jan 13, 2025
mo-tenstorrent
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #15692
Closes #596
Problem description
ARCH_NAME is still required when compiling tests
What's changed
Where test cases are ARCH_NAME dependent, generate an executable foreach ARCH.
Example
Currently, instead of generating
unit_tests_apiit generatesunit_tests_api_grayskullunit_tests_api_wormhole_b0unit_tests_api_blackholeApproach
The idea is simple. Any time a test directory faces issue due to ARCH_NAME include path removal, just triple the number of executables in that directory, and manually supply the include path required foreach arch.
Then update all references.
Checklist