-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12253: Batch Norm support for training mode #16592
Open
VirdhatchaniKN
wants to merge
9
commits into
main
Choose a base branch
from
virdhatchani/bn_training_impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
from
January 10, 2025 05:35
b1bc734
to
3040c55
Compare
VirdhatchaniKN
changed the title
Virdhatchani/bn training impl
#0: Batch Norm support for training mode
Jan 10, 2025
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
from
January 10, 2025 05:57
3040c55
to
931471a
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/batch_norm_impl
branch
from
January 10, 2025 06:26
84c1940
to
ad3e284
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
6 times, most recently
from
January 10, 2025 11:23
ec8c29a
to
9544031
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/batch_norm_impl
branch
2 times, most recently
from
January 11, 2025 13:28
5bfb6be
to
82af08f
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
3 times, most recently
from
January 11, 2025 13:59
c06805d
to
ef0ab21
Compare
VirdhatchaniKN
changed the title
#0: Batch Norm support for training mode
#12253: Batch Norm support for training mode
Jan 11, 2025
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
6 times, most recently
from
January 11, 2025 18:40
1fb2d75
to
aafada0
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/batch_norm_impl
branch
2 times, most recently
from
January 12, 2025 02:54
c19ce6f
to
8d1f48b
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
from
January 12, 2025 02:59
aafada0
to
258ea9b
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/batch_norm_impl
branch
from
January 12, 2025 10:24
8d1f48b
to
052177f
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
3 times, most recently
from
January 13, 2025 11:57
35247ad
to
32e1325
Compare
VirdhatchaniKN
requested review from
yan-zaretskiy,
eyonland,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
yugaoTT,
tt-aho and
asandhupatlaTT
as code owners
January 23, 2025 17:08
yugaoTT
approved these changes
Jan 23, 2025
ttnn/cpp/ttnn/operations/normalization/batch_norm/device/running_statistics_program_factory.cpp
Show resolved
Hide resolved
#include <cmath> | ||
|
||
namespace { | ||
namespace CMAKE_UNIQUE_NAMESPACE { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you want to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a namespace set in Unity's CMake configuration and is included across all program factories.
ttnn/cpp/ttnn/operations/normalization/batch_norm/device/running_statistics_program_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/normalization/batch_norm/device/running_statistics_program_factory.cpp
Outdated
Show resolved
Hide resolved
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
2 times, most recently
from
January 24, 2025 04:14
10bebff
to
a0aa222
Compare
VirdhatchaniKN
force-pushed
the
virdhatchani/bn_training_impl
branch
from
January 24, 2025 05:29
a0aa222
to
a3c0bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Github issues
Problem description
To implement batch normalization as device op
What's changed
Work done :
Checklist
All test have passed