Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to raise error on failed local/global tensor comparison #16585

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add option to raise error on failed local/global tensor comparison #16585

wants to merge 2 commits into from
+105 −4

Conversation

esmalTT
Copy link
Contributor

@esmalTT esmalTT commented Jan 9, 2025 •
edited
Loading

What's changed

  • Add option to raise error on failed local/global tensor comparison
    • Enabling 'comparison_model_should_raise_exception' will cause the program to crash when an invalid comparison is encountered.
    • This is useful for finding bugs in scenarios where a large number of operations are being run, since you can use the stack trace to localize bad comparison.
    • Add unit test to validate this new functionality
  • Add a warning to tell users that comparison mode cannot be used with fast dispatch.
  • Add golden function implementation for ttnn.conv2d

Checklist

@esmalTT esmalTT requested a review from mywoodstock January 9, 2025 23:15
@esmalTT esmalTT self-assigned this Jan 9, 2025
@esmalTT esmalTT force-pushed the esmal/conv-comp-mode branch 2 times, most recently from 00ce778 to 37a9317 Compare January 9, 2025 23:36
@esmalTT
Add option to raise error on failed local/global tensor comparison
0ab82e2 
Enabling 'comparison_model_should_raise_exception' will cause the
program to crash when an invalid comparison is encountered. This is
useful for finding bugs in scenarios where a large number of operations
are being run.

This commit also adds a warning to tell users that comparison mode
cannot be used with fast dispatch.
@esmalTT
Add golden function implementation for ttnn.conv2d
839997b
@esmalTT esmalTT force-pushed the esmal/conv-comp-mode branch from 37a9317 to 839997b Compare January 10, 2025 12:48
@esmalTT esmalTT marked this pull request as ready for review January 10, 2025 13:33
bbradelTT
bbradelTT approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@bbradelTT bbradelTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very useful.

Please document using it somewhere prominent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbradelTT bbradelTT bbradelTT approved these changes

@mywoodstock mywoodstock Awaiting requested review from mywoodstock

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@rfurko-tt rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@esmalTT esmalTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esmalTT @bbradelTT