Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Sanitize writes to mailbox on ethernet cores. #16574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbaumanTT
Copy link
Contributor

@jbaumanTT jbaumanTT commented Jan 9, 2025

Problem description

The NOC may be used to write data to the mailbox on ethernet cores, causing later programs to fail to launch.

What's changed

Modify the sanitizer to check that the mailbox isn't being written to directly on ethernet cores (outside the dispatcher, which is allowed to do that).

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant