[CCL] Add separate CMakeLists.txt for CCL ops #15649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aswinmcw
force-pushed
the
Aswinmcw/ccl_cmakelists
branch
from
abe4410 to
d61e1d6
Compare
SeanNijjar
approved these changes
Dec 3, 2024
|
@ayerofieiev-tt - is it okay if we make reference to experimental files from within the main CCL build file? |
Aswinmcw
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
yan-zaretskiy and
cfjchu
as code owners
Aswinmcw
force-pushed
the
Aswinmcw/ccl_cmakelists
branch
from
d61e1d6 to
1b89ff6
Compare
Comment on lines
25
to
31
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_gather_matmul/all_gather_matmul.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_gather_matmul/all_gather_matmul_pybind.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_gather_matmul/device/all_gather_matmul_op.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_gather_matmul/device/multi_core/all_gather_matmul_op_multi_core.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_reduce/all_reduce.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_reduce/all_reduce_pybind.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../experimental/ccl/all_reduce/device/all_reduce_op.cpp |
There was a problem hiding this comment.
maybe have a separate list for experimental/ccl instead?
ayerofieiev-tt
approved these changes
Dec 6, 2024
Aswinmcw
force-pushed
the
Aswinmcw/ccl_cmakelists
branch
2 times, most recently
from
fb22b49 to
42c94f2
Compare
Aswinmcw
force-pushed
the
Aswinmcw/ccl_cmakelists
branch
from
42c94f2 to
4a2bb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#15636
Problem description
Needs separate CMakeLists.txt for CCL ops
What's changed
Add separate CMakeLists.txt for CCL ops
Checklist