Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resize2d nightly models ops test #1345

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Update resize2d nightly models ops test #1345

merged 1 commit into from
Mar 3, 2025

Conversation

chandrasekaranpradeep
Copy link
Contributor

@chandrasekaranpradeep chandrasekaranpradeep commented Feb 28, 2025 •
edited
Loading

Resize2d(i.e upsample2d) op is supported in tt-forge-fe in this commit and in the latest run nightly models ops test (i.e https://github.com/tenstorrent/tt-forge-fe/actions/runs/13580014696) resize2d ops with bilinear mode test are failling with below error due to bilinear mode not supported for upsample op in tt-metal

E       RuntimeError: TT_THROW @ /proj_sw/user_dev/pchandrasekaran/Forge3/tt-forge-fe/third_party/tt-mlir/third_party/tt-metal/src/tt-metal/ttnn/cpp/ttnn/operations/pool/upsample/device/upsample_op.cpp:118: tt::exception
E       info:
E       Unsupported mode

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests675 ran542 passed133 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests617 ran482 passed135 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests675 ran542 passed133 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests617 ran482 passed135 skipped0 failed
TestResult
No test annotations available

@chandrasekaranpradeep chandrasekaranpradeep marked this pull request as ready for review February 28, 2025 10:12
ashokkumarkannan1
ashokkumarkannan1 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@ashokkumarkannan1 ashokkumarkannan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chandrasekaranpradeep chandrasekaranpradeep merged commit 08cdcb1 into main Mar 3, 2025
17 checks passed
@chandrasekaranpradeep chandrasekaranpradeep deleted the pchandrasekaran/resize2d_models_ops branch March 3, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvukobratTT nvukobratTT nvukobratTT approved these changes

@ashokkumarkannan1 ashokkumarkannan1 ashokkumarkannan1 approved these changes

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@dgolubovicTT dgolubovicTT Awaiting requested review from dgolubovicTT dgolubovicTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandrasekaranpradeep @nvukobratTT @ashokkumarkannan1