Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving coverage #35

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Improving coverage #35

merged 3 commits into from
Aug 21, 2020

Conversation

hhsecond
Copy link
Member

Description

  • Increasing coverage
  • .keys() for all shelfs

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #35 into master will increase coverage by 51.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #35       +/-   ##
===========================================
+ Coverage   40.42%   91.53%   +51.10%     
===========================================
  Files          21       21               
  Lines         653      685       +32     
  Branches       48       51        +3     
===========================================
+ Hits          264      627      +363     
+ Misses        389       47      -342     
- Partials        0       11       +11     
Impacted Files Coverage Δ
stockroom/parser.py 100.00% <100.00%> (+100.00%) ⬆️
stockroom/storages/data.py 83.33% <100.00%> (+83.33%) ⬆️
stockroom/storages/experiment.py 84.21% <100.00%> (+84.21%) ⬆️
stockroom/storages/model.py 83.13% <100.00%> (+83.13%) ⬆️
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_cli.py 100.00% <100.00%> (ø)
tests/test_experiment.py 100.00% <100.00%> (ø)
tests/test_model.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f643d83...1061090. Read the comment docs.

@hhsecond hhsecond force-pushed the coverage branch 2 times, most recently from a415e3e to 995a0e3 Compare August 21, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants