Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor spelling and typo fixes #971

Merged
merged 3 commits into from
May 17, 2019
Merged

minor spelling and typo fixes #971

merged 3 commits into from
May 17, 2019

Conversation

dvklopfenstein
Copy link
Contributor

@dvklopfenstein dvklopfenstein commented May 15, 2019

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

@zsdonghao
Copy link
Member

Thanks a lot for the contribution, however, I am not able to merge this PR before you update the changelog.md. Could you put your Github and PR IDs in to the changelog.md?

Many thanks.

@dvklopfenstein
Copy link
Contributor Author

Thank you very much for considering my pull request. I have updated the changelog.md with my GitHub ID and PR

@dvklopfenstein
Copy link
Contributor Author

dvklopfenstein commented May 16, 2019

Hello,

The error seen in both:

  • ci/cirlceci: test_sources_py2_cpu and
  • ci/cirlceci: test_sources_py2_cpu

is:

ERROR: No matching distribution found for scikit-learn==0.21.0 (from tensorlayer==2.0.0)

I do not believe my doc change resulted in this error.

MORE INFO: On the scikit web pageScikit-learn from 0.21 requires Python 3.5 or greater, but the tests that are failing are being run with Python 2.7 so perhaps a configuration file needs to be modified to use a different version of scikit-learn when using Python2.7.

I don't want to further edit anything in an attempt to address an ERROR, but am just reporting what I am seeing...

@zsdonghao zsdonghao merged commit 408f1d6 into tensorlayer:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants