Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weights -> all_weights, trainable_weights, nontrainable_weights #966

Merged
merged 9 commits into from
May 13, 2019
Merged

weights -> all_weights, trainable_weights, nontrainable_weights #966

merged 9 commits into from
May 13, 2019

Conversation

warshallrho
Copy link
Member

@warshallrho warshallrho commented May 13, 2019 •
edited
Loading

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

weights -> all_weights, trainable_weights, nontrainable_weights

@zsdonghao
Copy link
Member

Remember to update changelog.md and run yapf -i xxx.py to refactor the code.

@warshallrho warshallrho changed the title [WIP] weights -> all_weights, trainable_weights, nontrainable_weights weights -> all_weights, trainable_weights, nontrainable_weights May 13, 2019
ChrisWu1997
ChrisWu1997 approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@ChrisWu1997 ChrisWu1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! We should remind all WIP pr of this change.

@zsdonghao zsdonghao merged commit de705fd into tensorlayer:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisWu1997 ChrisWu1997 ChrisWu1997 approved these changes

@zsdonghao zsdonghao Awaiting requested review from zsdonghao

Assignees
No one assigned
Labels
waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warshallrho @zsdonghao @ChrisWu1997