Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package_info.py #1046

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Update package_info.py #1046

merged 2 commits into from
Sep 26, 2019

Conversation

luomai
Copy link
Member

@luomai luomai commented Sep 24, 2019 •
edited
Loading

Checklist

  • I've tested that my changes are compatible with the latest version of Tensorflow.
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

@luomai luomai requested a review from zsdonghao September 24, 2019 15:08
@luomai
Copy link
Member Author

luomai commented Sep 24, 2019 •
edited
Loading

Are there other places I need to update? @zsdonghao @JingqingZ

@luomai luomai changed the title Update package_info.py [WIP] Update package_info.py Sep 24, 2019
@luomai luomai requested a review from JingqingZ September 24, 2019 15:11
JingqingZ
JingqingZ approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@JingqingZ JingqingZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please make sure the CHANGELOG is updated accordingly.

@luomai luomai changed the title [WIP] Update package_info.py Update package_info.py Sep 26, 2019
@luomai luomai merged commit 04df1da into master Sep 26, 2019
@luomai luomai deleted the luomai-patch-1 branch September 26, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingqingZ JingqingZ JingqingZ approved these changes

@zsdonghao zsdonghao Awaiting requested review from zsdonghao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luomai @JingqingZ