Support nested layer customization and enable better 'in_channels' exception raise #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
Description
I briefly list the design below just for a reminder.
Each layer maintain a private attribute
self._layers
to store possible nested layer. When aLayer
is registered as an attribute of anotherLayer
, it is automatically added to the second layer'sself._layers
. Weights are collected recursively.Inner layer set to be unaware of
LayerNode
concept because it does not need to be involved in the model node graph. Inner layer is only regarded as the outer layer‘s 'private' attribute, which is not known by the model.MyLayer
would contain three weights:W
ofMyLayer
,W
andb
of the innerDense
.Now it is checked when setting
Layer
as an attribute of dynamicModel
. Ifin_channels
not provided, there will be an exception raised, e.g.