-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint errors #6944
Draft
smokestacklightnin
wants to merge
16
commits into
tensorflow:master
Choose a base branch
from
smokestacklightnin:ci/linting/fix-lint-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix lint errors #6944
smokestacklightnin
wants to merge
16
commits into
tensorflow:master
from
smokestacklightnin:ci/linting/fix-lint-errors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smokestacklightnin
force-pushed
the
ci/linting/fix-lint-errors
branch
from
October 27, 2024 02:10
b43e55c
to
ecf3409
Compare
smokestacklightnin
force-pushed
the
ci/linting/fix-lint-errors
branch
from
October 27, 2024 02:26
8e1fd34
to
bf43171
Compare
For remaining B008 violations, see [Issue 6945](tensorflow#6945)
smokestacklightnin
force-pushed
the
ci/linting/fix-lint-errors
branch
from
October 27, 2024 06:58
bf43171
to
bb24e15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current linting workflow checks only for linting errors on a per pull request basis, rather than the entire repo. That is for a given pull request, the linting workflow only checks the files changed in that workflow. This is because there are many linting errors.
This pull request is a first effort fixing linting errors that predate the linting workflow.
Changes include:
Footnotes
See Code inistantiates abstract base classes #6942, Abstract base classes have incorrectly decorated methods #6943, and Fixing Ruff
function-call-in-default-argument (B008)
causes test collection errors #6945 for remaining bugbear violations ↩