webgpu: fix: conditionally call deprecated GPUAdapter.requestAdapterInfo #8392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
GPUAdapter.requestAdapterInfo
is deprecated and non-standard.It's in use by
tfjs-backend-webgpu
, but the result is optional, and only used for a single optimization. Yet if called in an environment which doesn't support it, it will throw.By checking the feature's available before calling it, this unbreaks Deno runtime support for
tfjs-backend-webgpu
, which doesn't support this feature and throws.Testing/Verification
yarn test
andyarn lint
succeed. Verified basic example now works in Deno.Related
denoland/deno#22029