Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgpu: apply the new timestampWrites format #8048

Merged
merged 5 commits into from
Nov 3, 2023
Merged

webgpu: apply the new timestampWrites format #8048

merged 5 commits into from
Nov 3, 2023

Conversation

qjia7
Copy link
Contributor

@qjia7 qjia7 commented Nov 2, 2023

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

@qjia7 qjia7 requested review from gyagp and Linchenn November 2, 2023 09:36
gyagp
gyagp approved these changes Nov 2, 2023
View reviewed changes
Copy link

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR LGTM.
Note that we have some other places that are using "--disable-dawn-features=disallow_unsafe_apis", and we may need to clean them up in future.

@qjia7 qjia7 merged commit 9ae972e into tensorflow:master Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchenn Linchenn Linchenn approved these changes

@gyagp gyagp gyagp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qjia7 @gyagp @Linchenn