Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React native update tfjs to 4.2.0 #7451

Merged

Conversation

mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Mar 6, 2023

This PR is forked from #7415 and only updates TFJS, including adding missing definitions for isTypedArray and setTimeoutCustom to the react native platform. It does not attempt to update the demo app or any expo dependencies. These will be updated in a later PR.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Add missing definitions for setTimeoutCustom and isTypedArray to the react
native platform
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @Linchenn)

Copy link
Collaborator

@Linchenn Linchenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Matt for updating it!

Reviewable status: :shipit: complete! 2 of 1 approvals obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants