Update dockerfiles to support emsdk#4772
Conversation
|
I've tested building the containers locally, and I've built parts of tfjs with them, but I haven't done a full rebuild. I don't expect these changes to break anything since they only add new dependencies to the dockerfiles. |
lina128
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)
dockers/wasm-docker/Dockerfile, line 8 at r1 (raw file):
RUN apt-get update -qqy && apt-get install -qqy \ curl \
Do you need all of this? Better to just pick the ones you need. Otherwise, it increases docker building time at the beginning of each CI run.
dockers/wasm-docker/Dockerfile, line 21 at r1 (raw file):
pip3 install -U absl-py
Can you follow the same style as the release docker:
# Install absl
RUN pip3 install -U absl-py
lina128
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)
Update dockerfiles to support Emscripten's official Bazel toolchain, which #4769 adds.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is