Skip to content

Update dockerfiles to support emsdk#4772

Merged
lina128 merged 3 commits intotensorflow:masterfrom
mattsoulanille:update_dockerfiles
Mar 2, 2021
Merged

Update dockerfiles to support emsdk#4772
lina128 merged 3 commits intotensorflow:masterfrom
mattsoulanille:update_dockerfiles

Conversation

@mattsoulanille
Copy link
Member

@mattsoulanille mattsoulanille commented Mar 2, 2021

Update dockerfiles to support Emscripten's official Bazel toolchain, which #4769 adds.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@google-cla google-cla bot added the cla: yes label Mar 2, 2021
@mattsoulanille mattsoulanille requested a review from lina128 March 2, 2021 21:19
@mattsoulanille
Copy link
Member Author

I've tested building the containers locally, and I've built parts of tfjs with them, but I haven't done a full rebuild. I don't expect these changes to break anything since they only add new dependencies to the dockerfiles.

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @mattsoulanille)


dockers/wasm-docker/Dockerfile, line 8 at r1 (raw file):

RUN apt-get update -qqy && apt-get install -qqy \
        curl \

Do you need all of this? Better to just pick the ones you need. Otherwise, it increases docker building time at the beginning of each CI run.


dockers/wasm-docker/Dockerfile, line 21 at r1 (raw file):

pip3 install -U absl-py

Can you follow the same style as the release docker:

# Install absl
RUN pip3 install -U absl-py

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @mattsoulanille)

@lina128 lina128 merged commit 1f11f74 into tensorflow:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants