Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing directly when parsng Keras 2 layers #6826

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

yatbear
Copy link
Member

@yatbear yatbear commented Apr 9, 2024

Currently inbound node parsing (changed in #6823) is not backward compatible with Keras 2. Instead of failing directly, changed the code to return empty inbound node results.

Googlers, see the description in cl/622948159 for context.

Tested internally: cl/582334596

#keras3 #oncall

Verified

This commit was signed with the committer’s verified signature.
jvnipers Juniper
@yatbear yatbear changed the title Avoid failing directly when given a Keras 2 model Avoid failing directly when parsng Keras 2 layers Apr 9, 2024
@yatbear yatbear assigned bmd3k and unassigned bmd3k Apr 9, 2024
@yatbear yatbear requested review from bmd3k and arcra April 9, 2024 14:29
Copy link
Member

@arcra arcra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yatbear!

@yatbear yatbear merged commit 6f1cbcb into tensorflow:master Apr 10, 2024
13 checks passed
@yatbear yatbear deleted the keras branch April 10, 2024 20:58
AnuarTB pushed a commit to AnuarTB/tensorboard that referenced this pull request May 3, 2024
Currently inbound node parsing is not backward compatible with Keras 2. Instead of failing directly, changed the code to return empty inbound node results.

Googlers, see the description in cl/622948159 for context.

Tested internally: cl/582334596

#keras3 #oncall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants