Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes enableScalarColumnContextMenus flag #6809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoonji
Copy link
Member

@hoonji hoonji commented Mar 26, 2024

Motivation for features / changes

Context menus in Time series scalar tables are ready for use!

Technical description of changes

Removes the enableScalarColumnContextMenus feature flag and associated code

Detailed steps to verify changes work correctly (as executed by you)

Manually tested context menus in runs table, filterbar, scalar tables

@hoonji hoonji requested a review from bmd3k March 26, 2024 13:54
@@ -110,11 +110,6 @@ export const FeatureFlagMetadataMap: FeatureFlagMetadataMapType<FeatureFlags> =
queryParamOverride: 'enableScalarColumnCustomization',
parseValue: parseBoolean,
},
enableScalarColumnContextMenus: {
defaultValue: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preferred way to do this would have been to set defaultValue: true.

That way rolling it back is very slightly more straightforward - greater chance of avoiding merge conflicts and having a clean rollback commit.

And then delete the code, say, one or two weeks later?

But I leave that up to you to decide which way to go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops sorry I see now that your request in the email was just to set the defaultValue.

I'll send another PR for the defaultValue update and we can just apply this PR later when everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants