Skip to content

Migrate uses of struct.to_proto #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Migrate uses of struct.to_proto #6778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorboard/defs/internal/html.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ def _tb_combine_html_impl(ctx):
manifest = ctx.actions.declare_file("%s.pbtxt" % ctx.label.name)
ctx.actions.write(
output = manifest,
content = struct(
content = proto.encode_text(struct(
label = str(ctx.label),
src = manifest_srcs,
).to_proto(),
)),
)
manifests = depset([manifest], transitive = [manifests])

Expand Down
6 changes: 3 additions & 3 deletions tensorboard/defs/web.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _tf_web_library(ctx):
external_asset=[struct(webpath=k, path=v)
for k, v in ctx.attr.external_assets.items()])
params_file = _new_file(ctx, "-params.pbtxt")
ctx.actions.write(output=params_file, content=params.to_proto())
ctx.actions.write(output=params_file, content=proto.encode_text(params))
ctx.actions.write(
is_executable=True,
output=ctx.outputs.executable,
Expand Down Expand Up @@ -150,9 +150,9 @@ def _make_manifest(ctx, src_list):
manifest = _new_file(ctx, "-webfiles.pbtxt")
ctx.actions.write(
output=manifest,
content=struct(
content=proto.encode_text(struct(
label=str(ctx.label),
src=src_list).to_proto())
src=src_list)))
return manifest

def _run_webfiles_validator(ctx, srcs, deps, manifest):
Expand Down