Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump webtesting rules and uses versioned browser for tests. #6772

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Mar 1, 2024

  1. Bump webtesting rules and uses versioned browser for tests.

    The bazel web testing rules package provides versioned browsers for
    testing. The one from 0.3.3 was picked somewhat arbitrarily as it
    seems old enough to provide enough compatibility coverage, without being
    as old as the version we were using before.
    
    This change might produce some scuba tests to be updated.
    
    Alternatively, we can accomplish the same result we had before with our
    custom browser, but some of the rules that we use for this purpose have
    been removed/changed.
    
    In that case, we'd need to use the `platform_archive` rule, like they do
    [here]
    (https://github.com/bazelbuild/rules_webtesting/blob/9e9361ba887a3b687f537c02409b690b62fecdfe/web/versioned/browsers-0.3.3.bzl#L134),
    and then define a browser similarly like they do [here]
    (https://github.com/bazelbuild/rules_webtesting/blob/9e9361ba887a3b687f537c02409b690b62fecdfe/browsers/BUILD.bazel#L50),
    which in turn declares a dependency on [this file]
    (https://github.com/bazelbuild/rules_webtesting/blob/9e9361ba887a3b687f537c02409b690b62fecdfe/third_party/chromium/BUILD.bazel),
    which is the one that references the output from the `platform_archive`
    rule.
    arcra committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    7afbde1 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Updates rules_webtesting reference to point to latest release. Also f…

    …ixes formatting issues.
    arcra committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    dad6949 View commit details
    Browse the repository at this point in the history