Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoids bad protobuf version 4.24.0 #6746

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Avoids bad protobuf version 4.24.0 #6746

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77b6c32
Avoids bad protobuf version 4.24.0
arcra Feb 2, 2024
d8e267f
Adds back line break at the end of the file.
arcra Feb 2, 2024
0e5d207
Updates reference to TF protobuf version requirements.
arcra Feb 2, 2024
9095bcd
Removes line break at end and adds back space, to see if that gets ri…
arcra Feb 2, 2024
cdce39f
Removes space at the end of file.
arcra Feb 2, 2024
2fee774
Adds comment about issue with protobuf version 4.24.0
arcra Feb 2, 2024
c2b2dbb
Updates reference to protobuf 4.24.0 issue with a url.
arcra Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorboard/pip_package/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ numpy >= 1.12.0
# At the same time, any constraints we specify here must allow at least some
# version to be installed that is also compatible with TensorFlow's constraints:
# https://github.com/tensorflow/tensorflow/blob/9d22f4a0a9499c8e10a4312503e63e0da35ccd94/tensorflow/tools/pip_package/setup.py#L100-L107
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment still valid? (seems to point to an old commit. The most up-to-date constraints look different than ours).

Also, is there an easy reference/link explaining what's wrong with 4.24.0 that we can also add to this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the reference, but I think the comment is still valid. We don't need to have the exact same restrictions, we just need to have "at least some versions that is also compatible with TensorFlow's constraints".

protobuf >= 3.19.6
protobuf >= 3.19.6, != 4.24.0
setuptools >= 41.0.0 # Note: provides pkg_resources as well as setuptools
# A dependency of our vendored packages. This lower bound has not been correctly
# vetted, but I wanted to be the least restrictive we can, since it's not a new
Expand All @@ -34,4 +34,4 @@ tensorboard-data-server >= 0.7.0, < 0.8.0
# Stay on Keras 2 for now: https://github.com/keras-team/keras/issues/18467.
# TODO: Remove this after migrating to Keras 3.
tf-keras >= 2.15.0
werkzeug >= 1.0.1
werkzeug >= 1.0.1
Loading