Updates edit column menu to support hparam columns

[hoonji]

Motivation for features / changes

#6737 will allow hiding hparam columns from the scalar card tables, but there is currently no way to show them again. Toggling standard columns is currently being done in the edit columns menu - this is a natural place to also allow hparam column toggling.

Technical description of changes

• Creates a new section in the edit columns menu for showing hparam columns. The column is only shown when the hparam flag is enabled and is the same across single and range selection tables.
• Implements hparam column add, reorder, toggle from the edit columns menu.

Screenshots of UI changes (or N/A)

New hparams section:

Adding hparams:

Detailed steps to verify changes work correctly (as executed by you)

• Manually tested add/reorder/sort/filter/remove/hide in runs table, scalar table, and edit column menu.

[rileyajones]

I'm not sure this approach to adding hparam columns to the scalar card actually scales. The hparams data project is about to launch and experiments will have 1000s of hparams. Thus the importance of the search feature we built into the runs table columns selector. Rendering out 1000s of line items in the column selector there is going to get out of control quickly.

I was under the impression that the plan for adding hparam columns to the scalar card data table was to get rid of the current affordance and replace it with the newer ui.

[hoonji]

I'm not sure this approach to adding hparam columns to the scalar card actually scales. The hparams data project is about to launch and experiments will have 1000s of hparams. Thus the importance of the search feature we built into the runs table columns selector. Rendering out 1000s of line items in the column selector there is going to get out of control quickly.

I was under the impression that the plan for adding hparam columns to the scalar card data table was to get rid of the current affordance and replace it with the newer ui.

@rileyajones I suspect there may be a misunderstanding here somewhere -

To establish some ground truths:

• all hparam column adds must be done via the searchable column selector, whether it is accessed via the column context menus (Insert column Right/Left) or via the + button on the tables or in the edit columns menu
• the column selector can easily support ~5000 rows and starts lagging a bit on O(10000) rows. If we need to improve scroll performance, we can leverage things like virtual scroll

So I'm not exactly sure what the point of concern is here - to clarify, the hparam list above is only going to show the "added" columns, not all columns. Also, we can't get rid of this menu because it's the only UI that allows us to re-enable columns.

[rileyajones]

This is quite different from the UI that we had discussed. It was our plan to remove the scalar_column_editor all together and control all scalar card columns via the newer UI.

We have a meeting tomorrow, lets discuss this in detail then.

[hoonji]

@rileyajones To clarify next steps, IIUC we eventually want to completely eliminate the "edit table columns" and consolidate all add/remove/sort behavior to use only context menu actions.

Before this can be done, we first have to allow adding standard columns using the "select columns" affordance - as currently the only way to re-show standard columns (or show columns that are disabled by default) is via the "edit table columns" menu. The select columns affordance will be upgraded as described in the next phase - I'll keep the "edit table columns" menu alive 'til then.

(Note that this is just an FYI comment - this PR we can probably trash)