Embedding Projector: Move Supervise with parameters to t-SNE #6290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicialics
force-pushed
the
move_supervise
branch
from
bee3496
to
aa6d3b6
Compare
initialize input fix lint bookmark
alicialics
force-pushed
the
move_supervise
branch
from
aa6d3b6
to
7b6c1a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Supervise with parameters are only applicable to t-SNE projection. This moves it from data panel to projections panel, and simplifying code in the process (no longer needed to notify projection changes to the data panel)
Technical description of changes
Move Supervise by to the t-SNE panel
Screenshots of UI changes
Before:
After:
Detailed steps to verify changes work correctly (as executed by you)
verify Supervise By works
Alternate designs / implementations considered