Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding Projector: fix t-SNE control when switching projections #6287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Apr 4, 2023

Motivation for features / changes

If projection is switched from t-SNE to UMAP, t-SNE doesn't pause and the framerate would crash (5fps on M1 pro)
If projection is switched from t-SNE to PCA/Custom, t-SNE is stopped, so user has to restart t-SNE when switching back.

Technical description of changes

Pause t-SNE when switching away, resume t-SNE when

Screenshots of UI changes

N/A

Detailed steps to verify changes work correctly (as executed by you)

toggle from t-SNE to any other panel and back to t-SNE will resume t-SNE immediately

Alternate designs / implementations considered

@alicialics alicialics changed the title Embedding Projector: fix switching projections Embedding Projector: fix t-SNE control when switching projections Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants