Chore: use genrule.tools again instead of genrule.exec_tools #6238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
reviewed
Mar 14, 2023
Contributor
bmd3k
left a comment
bmd3k
left a comment
There was a problem hiding this comment.
Should we change the other two usages in our repo, too, for consistency, even if they don't get imported internally?
https://cs.opensource.google/search?q=exec_tools&ss=tensorflow%2Ftensorboard
The usage in tensorboard/defs/defs.bzl is refactored from one of the changes in #4031.
Contributor
Author
Yea, that seems like a good idea. Done. |
bmd3k
approved these changes
Mar 15, 2023
|
Thanks! |
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…low#6238) * Motivation for features / changes This is part of an internal Large Scale Change(googlers see b/265933639). In pr tensorflow#4031 we switch from using the tools(host mode) to using exec_tools(exec mode). This was done as part of a Large Scale change(Googlers see b/163558320). This was always supposed to be a temporary measure until the host mode was switched to use python3 by default. That has now happened so we are switching back to using genrule.tools. * Technical description of changes For reference, the difference between host and exec mode: genrule.tools uses host mode, which ignores the py_binary.python_version attribute and always use Python 3 genrule.exec_tools uses exec mode, which respects the py_binary.python_version attribute (unless an upstream host dependency forces all downstream targets to stay in host) * Detailed steps to verify changes work correctly (as executed by you) bazel clean bazel build tensorboard/components/tensor_widget:gen_tensor_widget_style bazel build tensorboard/components_polymer3/polymer:gen_plottable_style bazel build tensorboard/components/polymer:gen_plottable_style
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…low#6238) * Motivation for features / changes This is part of an internal Large Scale Change(googlers see b/265933639). In pr tensorflow#4031 we switch from using the tools(host mode) to using exec_tools(exec mode). This was done as part of a Large Scale change(Googlers see b/163558320). This was always supposed to be a temporary measure until the host mode was switched to use python3 by default. That has now happened so we are switching back to using genrule.tools. * Technical description of changes For reference, the difference between host and exec mode: genrule.tools uses host mode, which ignores the py_binary.python_version attribute and always use Python 3 genrule.exec_tools uses exec mode, which respects the py_binary.python_version attribute (unless an upstream host dependency forces all downstream targets to stay in host) * Detailed steps to verify changes work correctly (as executed by you) bazel clean bazel build tensorboard/components/tensor_widget:gen_tensor_widget_style bazel build tensorboard/components_polymer3/polymer:gen_plottable_style bazel build tensorboard/components/polymer:gen_plottable_style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an internal Large Scale Change(googlers see b/265933639).
In pr #4031 we switch from using the tools(host mode) to using exec_tools(exec mode). This was done as part of a Large Scale change(Googlers see b/163558320). This was always supposed to be a temporary measure until the host mode was switched to use python3 by default. That has now happened so we are switching back to using genrule.tools.
Technical description of changes
For reference, the difference between host and exec mode:
genrule.tools uses host mode, which ignores the py_binary.python_version attribute and always use Python 3
genrule.exec_tools uses exec mode, which respects the py_binary.python_version attribute (unless an upstream host
dependency forces all downstream targets to stay in host)
Detailed steps to verify changes work correctly (as executed by you)
bazel clean
bazel build tensorboard/components/tensor_widget:gen_tensor_widget_style
bazel build tensorboard/components_polymer3/polymer:gen_plottable_style
bazel build tensorboard/components/polymer:gen_plottable_style