projector: fix label/color legend #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
Oct 17, 2022
qihach64
pushed a commit
to qihach64/tensorboard
that referenced
this pull request
Dec 19, 2022
## Motivation for features / changes Inside the projector plugin, a legend for labels/colors should appear when selecting a field from the "Color by" drop-down menu yet is not displayed. ## Technical description of changes The `dom-if` property is misconfigured for the `vz-projector-legend` template. Co-authored-by: Marco Romanelli <[email protected]>
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
## Motivation for features / changes Inside the projector plugin, a legend for labels/colors should appear when selecting a field from the "Color by" drop-down menu yet is not displayed. ## Technical description of changes The `dom-if` property is misconfigured for the `vz-projector-legend` template. Co-authored-by: Marco Romanelli <[email protected]>
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
## Motivation for features / changes Inside the projector plugin, a legend for labels/colors should appear when selecting a field from the "Color by" drop-down menu yet is not displayed. ## Technical description of changes The `dom-if` property is misconfigured for the `vz-projector-legend` template. Co-authored-by: Marco Romanelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Inside the projector plugin, a legend for labels/colors should appear when selecting a field from the "Color by" drop-down menu yet is not displayed.
Technical description of changes
The
dom-ifproperty is misconfigured for thevz-projector-legendtemplate.Screenshots of UI changes
Before:
After:
Detailed steps to verify changes work correctly (as executed by you)
standalone_projector_config.jsonas config file (if run locally you need a simple webserver to serve the file via http)