build: explicitly require Python 3.7+ #5878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groszewn
force-pushed
the
drop_py_36
branch
2 times, most recently
from
be7b02c
to
bbd2b9a
Compare
nfelt
approved these changes
Aug 17, 2022
.github/workflows/ci.yml
Outdated
| @@ -214,7 +214,7 @@ jobs: | |||
| # flake8 should run on each Python version that we target, | |||
| # because the errors and warnings can differ due to language | |||
| # changes, and we want to catch them all. | |||
| python_version: ['3.6', '3.7'] | |||
| python_version: ['3.7', '3.8'] | |||
There was a problem hiding this comment.
Want to add 3.9 and 3.10 in addition to 3.8? We should be 3.10 compatible as of #5793, and while obviously we haven't been good about keeping this line up to date, the comment above has a rationale for running at least flake8 for every supported Python version.
If you do that we could also add 3.9 and 3.10 tags in both setup.py files as well.
There was a problem hiding this comment.
Good catch, updated!
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
* build: explicitly require Python 3.7+ Contributes to tensorflow#5725 * Run flake8 for all targeted python versions
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
* build: explicitly require Python 3.7+ Contributes to tensorflow#5725 * Run flake8 for all targeted python versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 is well past its EOL, so we should require 3.7+.
Contributes to #5725