Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen path prefix #5570

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Gen path prefix #5570

wants to merge 3 commits into from

Conversation

joveh
Copy link

@joveh joveh commented Feb 16, 2022

  • Motivation for features / changes
    Following the idea of @jdhayes in add path_prefix_from_file option, adding security by obscurity. This … #5541 we implemented the option gen_path_prefix

  • Technical description of changes
    new option in tensorboard call to improve security on multi-user systems.

  • Screenshots of UI changes

  • Detailed steps to verify changes work correctly (as executed by you)

  • Alternate designs / implementations considered

@bileschi
Copy link
Collaborator

Hello @joveh.

We are reluctant to add data-access-security focused features unless we were sure we could handle security well.

We are unlikely to accept this PR as it adds complexity to TensorBoard with little value beyond to serve the security use case, and putting data access security burden on TensorBoard expands our the mandate beyond our ability to execute.

Is it possible to manage this use case using existing external practices and not depending on OSS TensorBoard to provide load-bearing security guarantees? For instance, I understand that your particular use case is in a multi-user HPC system. Is it possible to mount the HPC filesystem using a form of secure remote file system and then run TensorBoard locally (or hosted behind e.g., NGINX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants