custom-scalars: fix bug in data download logic and add tests #3794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the custom scalars dashboard so the data download links work again. They have been failing on the backend with the following error due to an argument mismatch from when the
experiment
support was added:To prevent regressions we port the download behavior HTTP-level tests from #3793 to the custom scalars dashboard. Also tested manually by launching tensorboard with test data and confirming the downloads now work as expected.