Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DebuggerV2] Fix a few CSS issues in overall layout #3721

Merged
merged 2 commits into from
Jun 9, 2020
Merged

[DebuggerV2] Fix a few CSS issues in overall layout #3721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc5e1a
[DebuggerV2] Fix a few CSS issues in overall layout
caisq Jun 9, 2020
5f13e82
Fix vertical flex box in StackTraceComponent
caisq Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/debugger_component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,25 @@ limitations under the License.
==============================================================================*/

.bottom-section {
box-sizing: border-box;
border-top: 1px solid rgba(0, 0, 0, 0.12);
height: 34%;
padding-top: 6px;
width: 100%;
}

.debugger-container {
box-sizing: border-box;
background-color: #fff;
height: 100%;
overflow: hidden;
}

.top-section {
box-sizing: border-box;
height: 66%;
padding: 6px 0;
white-space: nowrap;
width: 100%;
}

Expand Down Expand Up @@ -56,6 +61,7 @@ tf-debugger-v2-source-files {

tf-debugger-v2-stack-trace {
display: inline-block;
height: 100%;
width: 30%;
}

Expand Down
3 changes: 3 additions & 0 deletions ...ard/plugins/debugger_v2/tf_debugger_v2_plugin/views/stack_trace/stack_trace_component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ limitations under the License.
height: 300px;
overflow-x: hidden;
overflow-y: auto;
/* Minus padding-left of the parent (stack-trace-container). */
width: calc(100% - 8px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of keeping track of all the padding of parents in mind, just use flex (with justify-content: stretch) where possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Normally yes, but StackTraceComponent is already flex in the column (vertical direction), which makes horizontal stretching a little complex. It's less complex to do it this way.

}

.stack-frame-container {
Expand Down Expand Up @@ -87,6 +89,7 @@ limitations under the License.

.stack-trace-container {
border-left: 1px solid rgba(0, 0, 0, 0.12);
box-sizing: border-box;
display: flexbox;
flex-direction: column;
font-size: 10px;
Expand Down