core: error msg for dynamic plugin in Colab #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colab is iterating on mechanism to use iframe within an output frame but it is not yet ready for consumption. As a result, all usage of iframes do not work properly in Colab and we would like to communicate that to users.
wchargin
reviewed
Jun 26, 2019
| <p> | ||
| Please see | ||
| <a | ||
| href="https://github.com/tensorflow/tensorboard/issues/1913" |
There was a problem hiding this comment.
Do you plan to broaden this issue from the profile plugin to “plugins
that use iframes” or similar? I’d be confused if I happened upon this
issue from the projector plugin.
(edit: I guess this is probably what you meant by the last line of the
PR description; SGTM.)
wchargin
approved these changes
Jun 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colab is iterating on mechanism to use iframe within an output frame but
it is not yet ready for consumption. As a result, all usage of iframes
do not work properly in Colab and we would like to communicate that to
users.
After merging this PR, we will update the issue #1913 accordingly.