-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker instructions in tensorboard-in-notebooks #2336
Add Docker instructions in tensorboard-in-notebooks #2336
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/tensorboard/pull/2336 Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows. |
@brunapinos Thanks for the contribution! ReviewNB can't render the diff, is it possible the new .ipynb file isn't quite formatted right? Also, is there a chance you might be able to reduce the size of the diff in the raw .ipynb? It looks like a lot of extra lines were moved around (indentation changes, re-ordering json fields) even though I believe content-wise you just added the one paragraph. |
@nfelt Thanks for the review! I'll reduce it! |
512d136
to
1aa9e53
Compare
@nfelt So, I had to give a push force to commit my changes with Colab. I don't know if it was the best way to do that. If you want, I can open another PR to commit these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reducing the diff! There are still some places where it seems like the changes are unrelated to the new content:
- cell_type fields have been re-ordered
- execution_count fields have been reset to 0
- embedded images have changed to use fully-qualified URLs rather than relative paths (which won't work on the documentation site that we use for tensorflow.org/tensorboard, and also doesn't render in the ReviewNB view any more)
Would you mind reverting those changes so we keep this focused on just the new paragraph?
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
eca7dfc
to
39d911d
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Now the diff is only referred to the paragraph added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks much better; thanks!
"Thus, run the container with the following command:\n", | ||
"\n", | ||
"```\n", | ||
"docker run -it -p 8888:8888 -p 6006 \\\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn’t seem to work for me—when I use %tensorboard
in the
Jupyter notebook, I still get “localhost refused to connect”. It works
if I change -p 6006
to -p 6006:6006
. Can/should we use that instead?
(I’m not super familiar with Docker, so if I’m missing something then
please fill me in!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was really missing :6006
in command. I've already fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, then—thanks a bunch!
Hi!
As described in #1952, it was necessary to add the information to expose the TensorBoard port when running the notebook using TensorFlow docker image. So, I added a paragraph in tensorboard-in-notebooks file, explaining the usage with docker, in Setup section: