Fixed incorrect runs-selector rendering #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nature of the bug: Sidebar tf-runs-selector is a bit trickier in term of layout: its height depends both on number/size of the content (# of runs) and size of the viewport (show scrollbar if it does not fit in the sidebar). To confine the size of the tf-runs-selector w.r.t the height of its container (whose height is not defined by content but its sibling sizes which are computed by respective descendents), we need to make each flex container `overflow: hidden`. `overflow: hidden` makes child and child-flex-container compute height w.r.t, the flex-container with `overflow: hidden`. When run numbers are low, we make tf-runs-selector's height computed w.r.t. descendent heights by not putting `height: 100%`. Confirmed the change both on Chrome 75 and Firefox 66.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of the bug:
Sidebar tf-runs-selector is a bit trickier in term of layout: its height
depends both on number/size of the content (# of runs) and size of the
viewport (show scrollbar if it does not fit in the sidebar).
To confine the size of the tf-runs-selector w.r.t the height of its
container (whose height is not defined by content but its sibling sizes
which are computed by respective descendents), we need to make each flex
container
overflow: hidden.overflow: hiddenmakes child andchild-flex-container compute height w.r.t, the flex-container with
overflow: hidden.When run numbers are low, we make tf-runs-selector's height computed
w.r.t. descendent heights by not putting
height: 100%.Confirmed the change both on Chrome 75 and Firefox 66.