build: use tf.test.main for mesh:demo_utils_test
#2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This test case already contains actual TensorFlow code, via the `GFile` use in the code under test. Within Google, such tests must be run via `tf.test.main()` or `absltest.main()`, and the TensorFlow-specific code should be in a `tf.test.TestCase` as well (though this is not strictly required). Test Plan: Verified that this patch fixes a test that’s broken when syncing into Google3. wchargin-branch: tf-test-mesh-test
|
WANT_LGTM=any |
nfelt
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This test case already contains actual TensorFlow code, via the
GFileuse in the code under test. Within Google, such tests must be run via
tf.test.main()orabsltest.main(), and the TensorFlow-specific codeshould be in a
tf.test.TestCaseas well (though this is not strictlyrequired).
Test Plan:
Verified that this patch fixes a test that’s broken when syncing into
Google3.
wchargin-branch: tf-test-mesh-test