core: move ES module path into FrontendMetadata
#2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
The two loading mechanisms are now specified in the same data object, so
switching from one to the other requires only a single change.
The HTTP API and the frontend are unchanged.
Test Plan:
Modify the scalar plugin’s `frontend_metadata` to use an ES module path:
```diff
diff --git a/tensorboard/plugins/scalar/scalars_plugin.py b/tensorboard/plugins/scalar/scalars_plugin.py
index 1b864a74..2e06c86a 100644
--- a/tensorboard/plugins/scalar/scalars_plugin.py
+++ b/tensorboard/plugins/scalar/scalars_plugin.py
@@ -85,7 +85,8 @@ class ScalarsPlugin(base_plugin.TBPlugin):
def frontend_metadata(self):
return super(ScalarsPlugin, self).frontend_metadata()._replace(
- element_name='tf-scalar-dashboard',
+ #element_name='tf-scalar-dashboard',
+ es_module_path='/magic.js',
use_data_selector=True,
)
```
Then, launch TensorBoard and note that the `plugins_listing` response
contains the right values for both the scalar and image plugins.
wchargin-branch: es-module-metadata
wchargin-source: 0a7e48329acba4b58ab9223e6b9ad7dbea98aff8 wchargin-branch: es-module-metadata
stephanwlee
approved these changes
Jun 5, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The two loading mechanisms are now specified in the same data object, so
switching from one to the other requires only a single change.
The HTTP API and the frontend are unchanged.
Test Plan:
Modify the scalar plugin’s
frontend_metadatato use an ES module path:Then, launch TensorBoard and note that the
plugins_listingresponsecontains the right values for both the scalar and image plugins.
wchargin-branch: es-module-metadata