build: upgrade rules_closure to HEAD
#2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This pulls in bazelbuild/rules_closure#383 to fix #2297, and integrates the same fix into our own `Vulcanize.java` for consistency. This diff includes a jscompiler upgrade from `v20190325` to `v20190528`. Test Plan: The `//tensorboard` target still builds and appears to run fine, with cursory inspection. Changing the `href` attribute of the help button in `tf-tensorboard` to `mailto:[email protected]` now builds and works properly; prior to this commit, that failed to build, as described in #2297. wchargin-branch: rules-closure-mailto-fix
Closed
nfelt
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pulls in bazelbuild/rules_closure#383 to fix #2297, and integrates
the same fix into our own
Vulcanize.javafor consistency.This diff includes a jscompiler upgrade from
v20190325tov20190528.Test Plan:
The
//tensorboardtarget still builds and appears to run fine, withcursory inspection.
Changing the
hrefattribute of the help button intf-tensorboardtomailto:[email protected]now builds and works properly; prior to thiscommit, that failed to build, as described in #2297.
wchargin-branch: rules-closure-mailto-fix