Fix invisible selector box #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cannoneyed is this addressing a GitHub issue? If not, would you be able to provide us with a repro step? I would like to know what this is fixing :). Thanks! |
|
@stephanwlee yeah, sorry about that - I filed it rather quickly and forgot to add the issue (#2195) To reproduce it, just go to the embedding projector and click the "Bounding Box selection" tool in the top toolbar, then click to drag a selection of points... the bounding box is currently invisible, and this PR fixes it!
|
stephanwlee
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the selector bounding box has disappeared in the embedding projector. This PR fixes it, making it visible again.
Fixes #2195.