test: ensure that build URLs are valid #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This tests that URLs point to the TensorFlow mirror (as opposed to the
Bazel mirror) and that they resolve to valid archives.
Test Plan:
Run `./tensorboard/tools/mirror_urls_test.sh`, and note that it passes
with no output. Then apply the following patch to add some bad URLs:
```diff
diff --git a/WORKSPACE b/WORKSPACE
index 3943b0cf..d3975dfe 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -9,6 +9,9 @@ http_archive(
urls = [
# tag 0.7.0 resolves to commit 6741f733227dc68137512161a5ce6fcf283e3f58 (2019-02-08 18:37:26 +0100)
"http://mirror.tensorflow.org/github.com/bazelbuild/bazel-skylib/archive/0.7.0.tar.gz",
+ "http://mirror.tensorflow.org/example.com/nonexistent.txt",
+ "http://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/archive/0.7.0.tar.gz",
+ "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/archive/0.7.0.tar.gz",
"https://github.com/bazelbuild/bazel-skylib/archive/0.7.0.tar.gz",
],
)
```
Re-run the test, and note that it fails with exit code 1 and this text:
```
The following URLs are not properly mirrored:
http://mirror.tensorflow.org/example.com/nonexistent.txt
Googlers, see http://b/133880558 for further instructions.
The following URLs point to the legacy Bazel mirror:
WORKSPACE:13: "http://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/archive/0.7.0.tar.gz",
WORKSPACE:14: "https://mirror.bazel.build/github.com/bazelbuild/bazel-skylib/archive/0.7.0.tar.gz",
Please update them to use http://mirror.tensorflow.org/ instead.
```
wchargin-branch: mirror-urls-test
wchargin-source: 3f549e6ed919d47770f7977cfb433116c176875a wchargin-branch: mirror-urls-test
wchargin-branch: mirror-urls-test # Conflicts: # .travis.yml
wchargin-source: a3c563dc262c3ecf8567816297cf54b0dc4df065 wchargin-branch: mirror-urls-test
wchargin-source: 9a50cec7bef035729fc363da2c3c7f63d6b83834 wchargin-branch: mirror-urls-test
nfelt
approved these changes
May 31, 2019
| # shellcheck disable=SC2016 | ||
| check_cmd='curl -sfL "$1" >/dev/null || printf "%s\n" "$1"' | ||
| # shellcheck disable=SC2016 | ||
| exclude='${version}' # as in `ci/download_bazel.sh` |
There was a problem hiding this comment.
Can we just exclude the specific ci/download_bazel.sh file itself? That seems less brittle.
| printf '%s\n' 'The following URLs are not properly mirrored:' | ||
| cat "${unresolved_urls_file}" | ||
| printf '%s\n' \ | ||
| 'Googlers, see http://b/133880558 for further instructions.' \ |
There was a problem hiding this comment.
More important that instructions for Googlers I think are instructions for what to do as a non-core-TB-team member who gets this error when sending a PR. Probably something like "please comment on your PR asking a TensorBoard core team member to mirror the URLs as per instructions in http://b/133880558".
wchargin-source: 70eeb29a52fc768ff34982e07060cd83d7d8a6ee wchargin-branch: mirror-urls-test
wchargin
changed the title
wchargin
changed the title
wchargin
commented
May 31, 2019
| # shellcheck disable=SC2016 | ||
| check_cmd='curl -sfL "$1" >/dev/null || printf "%s\n" "$1"' | ||
| # shellcheck disable=SC2016 | ||
| exclude='${version}' # as in `ci/download_bazel.sh` |
| printf '%s\n' 'The following URLs are not properly mirrored:' | ||
| cat "${unresolved_urls_file}" | ||
| printf '%s\n' \ | ||
| 'Googlers, see http://b/133880558 for further instructions.' \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This tests that URLs point to the TensorFlow mirror (as opposed to the
Bazel mirror) and that they resolve to valid archives.
Test Plan:
Run
./tensorboard/tools/mirror_urls_test.sh, and note that it passeswith no output. Then apply the following patch to add some bad URLs:
Re-run the test, and note that it fails with exit code 1 and this text:
Tested on Git v2.15.1, which is what Travis uses.
wchargin-branch: mirror-urls-test