fix tooltip position #2285
Merged
fix tooltip position #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
reviewed
May 29, 2019
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
stephanwlee
requested changes
May 29, 2019
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
stephanwlee
reviewed
May 29, 2019
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
Calculate the tooltip position based on the layout.
stephanwlee
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The tooltip displayed when hovering on image of a pod is positioned suboptimally, this PR position the tooltip better. profile: pod viewer tooltip position #2284
Technical description of changes
Screenshots of UI changes
Detailed steps to verify changes work correctly (as executed by you)
bazel run tensorboard:tensorboard -- --logdir=gs://cloud-tpu-tools
Alternate designs / implementations considered