Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for TPU profiling #2262

Merged
merged 4 commits into from
May 24, 2019

Conversation

qiuminxu
Copy link
Contributor

@qiuminxu qiuminxu commented May 22, 2019

  • Motivation for features / changes
    StartTracing API has more options to config how to profile a model. Add that to the capture profile pop up.
  • Technical description of changes
  1. Add work_list, num_tracing_attempts and include_dataset_ops to the pop up.
  2. Trim the string of the ProfilerServiceAddress to remove leading and trailing spaces.
  3. Add auto-validate to the input field.
  4. Fix a bug that the "_profilerServiceAddress" should be passed into the shouldDisableCaptureProfileButton instead of the "profilerServiceAddress".
  • Screenshots of UI changes
    capture_profile_button

  • Detailed steps to verify changes work correctly (as executed by you)
    bazel run tensorboard/plugins/profile:profile_demo
    bazel run tensorboard:tensorboard -- --logdir=/tmp/profile_demo

  • Alternate designs / implementations considered

@qiuminxu qiuminxu requested a review from qqfish May 22, 2019 23:05
@qiuminxu qiuminxu force-pushed the improve_capture_button branch from 457836c to 666735d Compare May 22, 2019 23:37
@wchargin wchargin requested review from wchargin and removed request for wchargin May 23, 2019 18:13
@qiuminxu qiuminxu requested a review from wchargin May 24, 2019 15:06
Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo inline. Thanks!

@qiuminxu qiuminxu merged commit e3b9963 into tensorflow:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants