-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance and scalability of pod viewer #2254
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/stack_bar_chart/stack-bar-chart.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/stack_bar_chart/stack-bar-chart.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
…uceSyncDurationUs. Src(Dst)CoreId to Src(Dst)CoreIds. Remove replica id.
Motivation for features / changes
When loading a large trace (~50MB), pod viewer takes a long time to render (>30s) and crashes the browser when changing the step or metric id. This change improves the logic and reduces the rendering and scripting time to ~1s.
Technical description of changes
proto.ts reflects this changes.
a. Change the _computeTopoData to not be triggered by changes in selectedMetricIdx. When selectedMetricIdx changes, we will only change the color of the cards (instead of redrawing).
b. Remove the channel selection in topology-graph. The user can hover over the channel bars and select for the channel.
c. Instead of drawing all the links at the beginning and change the visibility (this creates too many dom elements and causes browser to crash), this change only draws the links that with the selected channel id.
Screenshots of UI changes
Detailed steps to verify changes work correctly (as executed by you)
bazel run :tensorboard -- --logdir=gs://cloud-tpu-tools-df
Select test run, and pod viewer tool. Under the 'new' host is the new trace, and others are old traces.
Alternate designs / implementations considered