Remove compatibility check from hot path #1686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a performance bottleneck in
event_file_loader.RawEventFileLoader
by caching the result of a TensorFlow compatibility check.The
event_file_loader_test
test succeeds under bothtensorflow==1.7
(the latest TensorFlow release that needs the compatibility check) andtf-nightly==1.13.0.dev20181211
, but there are several other tests failing undertensorflow==1.7
. These tests also fail at the head of master 0d4b71b when usingtensorflow==1.7
.Fixes #1676