FIX: data-loader now responds to loadKey changes #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please refer to tensorflow#1499 for details. The observer to the `loadKey` change was not triggered even when it changed. Weirdly, the complex observer for `dataToLoad` was triggering fine. Due to the issue, the line-chart appeared stale even when its tag/run pair has changed.
nfelt
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #1499 for details.
The observer to the
loadKeychange was not triggered even when itchanged. Weirdly, the complex observer for
dataToLoadwas triggeringfine.
Due to the issue, the line-chart appeared stale even when its tag/run
pair has changed.