Expose tagFilter persistence to hash #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagFilter was persisted via local storage which was harder to grok just looking at the browser. Instead, we now expose it via hash. This change also: - fixes the issue where simply navigating from another plugin to scalars plugin removed/resetted the tagRegex. - apply common tagRegex component to audio dashboard to leverage the storage
nfelt
approved these changes
Oct 1, 2018
stephanwlee
added a commit
to stephanwlee/tensorboard
that referenced
this pull request
Oct 5, 2018
Repro step: 1. Open TB in scalar dashboard 2. Type something into tag filter 3. Navigate to audio dashboard 4. See nothing <- bug The regression was caused by tensorflow#1475 which has broken the Polymer complex observer.
stephanwlee
added a commit
to stephanwlee/tensorboard
that referenced
this pull request
Oct 10, 2018
tf-tag-filterer, correctly, defined its property `tag-filter` as readOnly and this broke the data connection between `paper-input`. Between the paper-input and the filterer, there should be a two-way binding of its value whereas all the consumers of the tf-tag-filterer should only read from the component. Now, using the private property, `_tagFilter`, we establish the two-way binding while the public property is only used to publish the change. Note: bug was introduced over tensorflow#1483, tensorflow#1475, and tensorflow#1493.
stephanwlee
added a commit
that referenced
this pull request
Oct 10, 2018
tf-tag-filterer, correctly, defined its property `tag-filter` as readOnly and this broke the data connection between `paper-input`. Between the paper-input and the filterer, there should be a two-way binding of its value whereas all the consumers of the tf-tag-filterer should only read from the component. Now, using the private property, `_tagFilter`, we establish the two-way binding while the public property is only used to publish the change. Note: bug was introduced over #1483, #1475, and #1493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagFilter was persisted via local storage which was harder to grok just
looking at the browser. Instead, we now expose it via hash.
This change also:
scalars plugin removed/resetted the tagRegex.
storage