FIX: line-chart is rendered properly (no-shrink) #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using paginated to scroll through charts quickly, you will trigger the chart creation (which is debounced for 350ms). The chart creation, even if it is no longer in foreground and is "display:none"d, it will resume drawing and result in very shrunken line-chart. There has been some detector of such bad draw but it did not account for the debounce logic in the line-chart. To mitigate the problem, we now listen to on Component#onAnchor event to listen to DOM mounting to detect whether we have a bad draw: drawn in the background. Alternatively, we can cancel debounce when tf component detects the backgroundness by either creating a new state in chart, `active`, or a method `cancelMakeChart`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using paginated to scroll through charts quickly, you will trigger
the chart creation (which is debounced for 350ms). The chart creation,
even if it is no longer in foreground ("display:none"d), it will draw and result
in a shrunken line-chart. There is a bad draw detection logic to remedy the
problem, but it did not account for the debounce logic in the line-chart.
To mitigate the problem, we now listen to on Plottable.Component#onAnchor
event to known when a chart is mounted on DOM and know when a drawn
happened while it was in the background.
Alternatively, we can cancel the chart creation debounce by either creating
a new state in chart,
active, or a methodcancelMakeChart.