Session started at Line 169 is closed after the use #1378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sessions close themselves upon deletion/garbage collection, so after it's out of scope it should eventually get cleaned up, I would have thought. Was this fixing some specific issue you had? Also, the code under plugins/hparams is stale code - it will probably be replaced completely at some future date. |
|
I was looking at this comment and thought it might be good practise to close the session |
|
I mean, it doesn't hurt to close it but it doesn't seem particularly necessary to me given that the resources will be cleaned up anyway, and this is only demo code. |
|
Closing due to inactivity and since I'm not sure closing the session explicitly is an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session started at line 169 is not closed after use.
This PR closes that session after its usage.